Add AwsQueryCompatible trait #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Jul 23, 2022
...raits/src/main/java/software/amazon/smithy/aws/traits/protocols/AwsQueryCompatibleTrait.java
Outdated
Show resolved
Hide resolved
...raits/src/main/java/software/amazon/smithy/aws/traits/protocols/AwsQueryCompatibleTrait.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
fossand
branch
4 times, most recently
from
7eb4ef9 to
6bcfb4a
Compare
AndrewFossAWS
force-pushed
the
fossand
branch
from
6bcfb4a to
eb0900b
Compare
sugmanue
previously requested changes
Sep 15, 2022
...raits/src/main/java/software/amazon/smithy/aws/traits/protocols/AwsQueryCompatibleTrait.java
Outdated
Show resolved
Hide resolved
...raits/src/main/java/software/amazon/smithy/aws/traits/protocols/AwsQueryCompatibleTrait.java
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
fossand
branch
6 times, most recently
from
b14f9bf to
9bd6134
Compare
AndrewFossAWS
changed the title
mtdowling
requested changes
Sep 16, 2022
smithy-aws-traits/src/main/resources/META-INF/smithy/aws.protocols.smithy
Outdated
Show resolved
Hide resolved
AndrewFossAWS
force-pushed
the
fossand
branch
5 times, most recently
from
fe2cb24 to
bd46b89
Compare
mtdowling
approved these changes
Sep 19, 2022
kstich
reviewed
Sep 19, 2022
smithy-aws-protocol-tests/model/awsJson1_0WithQueryCompatible/main.smithy
Outdated
Show resolved
Hide resolved
...hy/aws/traits/errorfiles/protocols/aws-query-compatible-does-not-support-non-aws-json.errors
Outdated
Show resolved
Hide resolved
...hy/aws/traits/errorfiles/protocols/aws-query-compatible-does-not-support-non-aws-json.smithy
Show resolved
Hide resolved
This commit introduces the `aws.protocols#awsQueryCompatible` trait which allows backward compatibility when migrating from awsQuery to awsJson1_0.
AndrewFossAWS
force-pushed
the
fossand
branch
from
bd46b89 to
31ed5a3
Compare
kstich
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This commit adds
aws.protocols#awsQueryCompatibletrait which allows backward compatibility when migrating fromawsQuerytoawsJson1_0.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.