Handle unknown model versions for built-shapes #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
reviewed
Jul 21, 2022
smithy-model/src/main/java/software/amazon/smithy/model/loader/ModelAssembler.java
Outdated
Show resolved
Hide resolved
The handling of unknown model versions for built shapes needs to make no assumptions about the version of provided shapes. Instead, it should use the UNKNOWN version which allows for any kind of 1.0 or 2.0 trait/shape, but still attempts to convert 1.0 -> 2.0 compatible models when loading shapes. This was a little haphazard before and we exposed controls to set the assumed parsed version that have now been removed. I don't think there's a reasonable use case where automated tooling will set that right now.
mtdowling
force-pushed
the
idl-2-unknown-version
branch
from
dd0b094 to
5086534
Compare
kstich
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of unknown model versions for built shapes needs
to make no assumptions about the version of provided shapes.
Instead, it should use the UNKNOWN version which allows for any
kind of 1.0 or 2.0 trait/shape, but still attempts to convert
1.0 -> 2.0 compatible models when loading shapes. This was a
little haphazard before and we exposed controls to set the
assumed parsed version that have now been removed. I don't think
there's a reasonable use case where automated tooling will set
that right now.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.