Add helper to convert Symbol to SymbolReference #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
approved these changes
May 12, 2022
mtdowling
force-pushed
the
add-symbol-to-reference-method
branch
from
23fc27e to
999d798
Compare
gosar
reviewed
May 13, 2022
smithy-codegen-core/src/main/java/software/amazon/smithy/codegen/core/Symbol.java
Outdated
Show resolved
Hide resolved
smithy-codegen-core/src/main/java/software/amazon/smithy/codegen/core/Symbol.java
Outdated
Show resolved
Hide resolved
It's sometimes necessary to obsfuscate names and use aliases in symbols that refer to other symbols. Using a SymbolReference could work here, but not if you need to wire it up to a SymbolProvider. These two helper methods create a Symbol that uses an alias as its name, no namespace, and adds a reference to the original symbol. It's essentially a helper method to do what things like the Smithy TypeScript generator are already doing in their symbol providers when referring to built-in language types that could conflict with Smithy generated types.
mtdowling
force-pushed
the
add-symbol-to-reference-method
branch
from
999d798 to
4880500
Compare
kstich
approved these changes
May 16, 2022
gosar
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.