-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Camel Case linter to automatically detect if upper or lower … #1217
Conversation
…camel should be enforced for consistency
smithy-linters/src/main/java/software/amazon/smithy/linters/CamelCaseValidator.java
Outdated
Show resolved
Hide resolved
I wonder of instead of needing to explicitly list namespaces to ignore (which is kind of breaking abstractions because this package shouldn't know about aws traits), we could instead validate services closures and potentially per/namespace? So first we validate service closures by iterating over each service shape and use a Then, if we really wanted to and maybe we do this later, we could track shapes that weren't in any service closure and then validate per/namespace. That would catch things like inconsistencies across traits in a single namespace. |
…camel should be enforced for consistency
Issue #, if available:
Users who consistently use upper camel for member shape member names will otherwise be flooded with extraneous violations that complain their names are not lower camel.
Description of changes:
With this change, we will add a new (default) mode to automatically detect whether the model uses upper or lower camel case more, and enforce that pattern.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.