Fix trait source locations #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes trait source locations from the IDL to start at the trait itself rather than at the start of the trait's node definition. This is particularly important for annotation traits where the source location previously pointed to the column *after* the trait, which doesn't necessarily even exist. The following shows where the source location used to point: ``` @annotation ^ @annotationWithParens() ^ @listTrait(["foo"]) ^ @structuredTrait({ ^ "foo": "bar" }) @structuredTraitWithoutBraces( foo: "bar" ^ ) @primitiveTrait(true) ^ ``` And this shows where they point now: ``` @annotation ^ @annotationWithParens() ^ @listTrait(["foo"]) ^ @structuredTrait({ ^ "foo": "bar" }) @structuredTraitWithoutBraces( ^ foo: "bar" ) @primitiveTrait(true) ^ ```
mtdowling
approved these changes
Mar 22, 2022
| @@ -68,6 +70,26 @@ public void loadsAppropriateSourceLocations() { | |||
| }); | |||
| } | |||
|
|
|||
| @Test | |||
| public void loadsAppropriateTraitSourceLocations() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes trait source locations from the IDL to start at the trait
itself rather than at the start of the trait's node definition. This
is particularly important for annotation traits where the source
location previously pointed to the column after the trait, which
doesn't necessarily even exist.
The following shows where the source location used to point:
And this shows where they point now:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.