Add multi-code-unit characters to length validation tests #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1090
Description of changes:
Server implementations that naively use code units instead of code points to
evaluate length constraints will give incorrect results. This adds parameters
to the existing string length tests that use multi-code-unit characters to
generate strings that will meet the constraints if code units are counted,
but properly fail the constraints if code points are counted.
I tested this by running them without the fixes in smithy-lang/smithy-typescript#510 and observing that they fail, and then running them with the fixes and observing that they pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.