Add input and output traits with inlined IO #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
idl-2.0
branch
from
437cff5 to
9a1a8e4
Compare
This updates inlined IO shapes to automatically include the input and output traits.
JordonPhillips
force-pushed
the
auto-io-traits
branch
from
7ed2941 to
4981a3a
Compare
kstich
reviewed
Dec 8, 2021
smithy-model/src/main/java/software/amazon/smithy/model/loader/IdlModelParser.java
Show resolved
Hide resolved
smithy-model/src/main/java/software/amazon/smithy/model/shapes/SmithyIdlModelSerializer.java
Show resolved
Hide resolved
kstich
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates inlined IO shapes to automatically include the input and output traits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.