Use `Identity` instead of `Credentials` in signing code #2913

Velfi · 2023-08-09T17:59:51Z

This PR replaces the access_key, secret_key, and session token fields of signing params with the Orchestrator's Identity type.

Checklist

I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

github-actions · 2023-08-09T18:27:03Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

rcoh

overall I think this is the right change. Personally, though, I'd keep Credentials on all the private locations and validate very early on that it is indeed credentials inside. We can also have a .credentials method on the signing params builder that accepts credentials—no reason we can't have both credentials and identity.

aws/rust-runtime/aws-sigv4/src/http_request/canonical_request.rs

aws/rust-runtime/aws-sigv4/src/lib.rs

github-actions · 2023-08-09T19:51:20Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-09T21:38:34Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-10T15:26:41Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-10T16:02:41Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-10T16:41:26Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-10T21:04:03Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-11T16:57:30Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-14T15:47:42Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-17T16:05:42Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-17T17:17:00Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2023-08-17T18:00:55Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

jdisanti

Looks good. Just two minor comments.

jdisanti · 2023-08-17T23:00:34Z

aws/rust-runtime/aws-sigv4/src/http_request/error.rs

@@ -52,6 +65,7 @@ enum CanonicalRequestErrorKind {
    InvalidHeaderValue { source: InvalidHeaderValue },
    InvalidUtf8InHeaderValue { source: Utf8Error },
    InvalidUri { source: InvalidUri },
+    UnsupportedCredentialType,


Should be called UnsupportedIdentityType

jdisanti · 2023-08-17T23:01:33Z

aws/rust-runtime/aws-sigv4/src/lib.rs

@@ -29,14 +30,11 @@ pub mod event_stream;
 pub mod http_request;

 /// Parameters to use when signing.
+// #[derive(Debug)] is safe because `Identity` handles redaction.


Identity doesn't handle redaction, but the data inside of it is supposed to.

I'll clarify that.

github-actions · 2023-08-18T15:05:40Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
No codegen difference in the Client Test
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Velfi requested a review from a team as a code owner August 9, 2023 17:59

Velfi added the breaking-change This will require a breaking change label Aug 9, 2023

Velfi requested a review from a team as a code owner August 9, 2023 19:17

rcoh reviewed Aug 9, 2023

View reviewed changes

aws/rust-runtime/aws-sigv4/src/http_request/canonical_request.rs Outdated Show resolved Hide resolved

aws/rust-runtime/aws-sigv4/src/lib.rs Outdated Show resolved Hide resolved

aws/rust-runtime/aws-sigv4/src/lib.rs Outdated Show resolved Hide resolved

Velfi mentioned this pull request Aug 10, 2023

Add Sigv4A support for the orchestrator #2890

Closed

merge main

f0573aa

Velfi force-pushed the zhessler-refactor-sigv4-identity branch from 9eb3bd8 to f0573aa Compare August 17, 2023 16:49

Merge branch 'main' into zhessler-refactor-sigv4-identity

81fd912

Velfi added the needs-sdk-review label Aug 17, 2023

jdisanti approved these changes Aug 17, 2023

View reviewed changes

jdisanti removed the needs-sdk-review label Aug 17, 2023

update code in response to PR comments

49bcabc

Velfi enabled auto-merge August 18, 2023 14:28

Velfi added this pull request to the merge queue Aug 18, 2023

Merged via the queue into main with commit 39c6476 Aug 18, 2023

Velfi deleted the zhessler-refactor-sigv4-identity branch August 18, 2023 15:14

NickDarvey mentioned this pull request Jun 25, 2024

chore: upgrade aws-config for aarch64-pc-windows support lancedb/lance#2510

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `Identity` instead of `Credentials` in signing code #2913

Use `Identity` instead of `Credentials` in signing code #2913

Velfi commented Aug 9, 2023 •

edited

Loading

github-actions bot commented Aug 9, 2023

rcoh left a comment

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 11, 2023

github-actions bot commented Aug 14, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

jdisanti left a comment

jdisanti Aug 17, 2023

jdisanti Aug 17, 2023

Velfi Aug 18, 2023

github-actions bot commented Aug 18, 2023

Use Identity instead of Credentials in signing code #2913

Use Identity instead of Credentials in signing code #2913

Conversation

Velfi commented Aug 9, 2023 • edited Loading

Checklist

github-actions bot commented Aug 9, 2023

rcoh left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 9, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 10, 2023

github-actions bot commented Aug 11, 2023

github-actions bot commented Aug 14, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

github-actions bot commented Aug 17, 2023

jdisanti left a comment

Choose a reason for hiding this comment

jdisanti Aug 17, 2023

Choose a reason for hiding this comment

jdisanti Aug 17, 2023

Choose a reason for hiding this comment

Velfi Aug 18, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 18, 2023

Use `Identity` instead of `Credentials` in signing code #2913

Use `Identity` instead of `Credentials` in signing code #2913

Velfi commented Aug 9, 2023 •

edited

Loading