Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error message for SSO credential providers #2722

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

rcoh
Copy link
Collaborator

@rcoh rcoh commented May 23, 2023

Motivation and Context

The current error if the SSO error message is not enabled is inscrutable and doesn't point the customer towards the removed feature.

Description

Fix the error message, add tests.

Testing

tests

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcoh rcoh requested review from a team as code owners May 23, 2023 18:51
@rcoh rcoh force-pushed the better-sso-error branch from b41318a to d7328b0 Compare May 23, 2023 18:51
@rcoh rcoh enabled auto-merge May 23, 2023 19:03
@rcoh rcoh added this pull request to the merge queue May 23, 2023
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

Merged via the queue into main with commit bbe9d52 May 23, 2023
@rcoh rcoh deleted the better-sso-error branch May 23, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants