Fix bug where string builtIns were not supported #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
force-pushed
the
default-string-builtins
branch
2 times, most recently
from
2922165
to
ce27b3d
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
approved these changes
Jan 3, 2023
jjant
reviewed
Jan 3, 2023
| rustBlockTemplate("#{Params}", "Params" to paramsStruct()) { | ||
| parameters.toList().forEach { parameter -> | ||
| rust("${parameter.memberName()}: self.${parameter.memberName()}") | ||
| parameter.default.orNull()?.also { default -> rust(".or(Some(${value(default)}))") } | ||
| parameter.default.orNull()?.also { default -> rust(".or_else(||Some(${value(default)}))") } |
There was a problem hiding this comment.
Nit: space
Suggested change
| parameter.default.orNull()?.also { default -> rust(".or_else(||Some(${value(default)}))") } | |
| parameter.default.orNull()?.also { default -> rust(".or_else(|| Some(${value(default)}))") } |
| @@ -255,10 +255,11 @@ internal class EndpointParamsGenerator(private val parameters: Parameters) { | |||
| "ParamsError" to paramsError(), | |||
| ) { | |||
| val params = writable { | |||
| Attribute.Custom("allow(clippy::unnecessary_lazy_evaluations)").render(this) | |||
There was a problem hiding this comment.
when it's a boolean value, the generated code isn't a function invocation
| val node = this | ||
| return writable { | ||
| when (node) { | ||
| is StringNode -> rust("Some(${node.value.dq()}.to_string())") |
There was a problem hiding this comment.
What was the fix? I fail to see it 🤔
There was a problem hiding this comment.
this is an unrelated refactoring
rcoh
force-pushed
the
default-string-builtins
branch
from
ce27b3d
to
4e83dd5
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
String builtIn parameters resulted in a compilation error
Description
Fix EP2 bug with builtIn resolution
Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.