Improve credentials tracing #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These spans are handled more generically in the default chain.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Velfi
reviewed
Dec 6, 2022
| @@ -152,7 +152,7 @@ impl ImdsCredentialsProvider { | |||
| Err(ImdsError::ErrorResponse(context)) | |||
| if context.response().status().as_u16() == 404 => | |||
| { | |||
| tracing::info!( | |||
| tracing::warn!( | |||
Velfi
approved these changes
Dec 6, 2022
| let future = Timeout::new(loader.provide_credentials(), timeout_future); | ||
| cache | ||
| let start_time = Instant::now(); |
There was a problem hiding this comment.
I'm wondering if we should use tokio::time::Instant in this so that this is more controllable in tests. Maybe it would be worth testing cache miss time? IDK
There was a problem hiding this comment.
Using tokio::time::Instant in tests is fine, but I'm not as sold on using it in the actual code (without abstracting it in some way) since it requires the time feature, which pulls in Tokio's async sleep. I don't think this specific case really needs a test.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds an
infoevent for each time there is a credentials cache miss with the time it took to reload credentials, removes some duplicate provider spans, and adjusts some event/span levels.Checklist
CHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.