Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 customization to prevent accidental data deletion for AbortMultipartUpload requests with no ID #1957

Closed
Velfi opened this issue Nov 7, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Velfi
Copy link
Contributor

Velfi commented Nov 7, 2022

The AbortMultiPartUpload API is ambiguous and will delete an object if no ID is passed, rather than returning an error. Add a customization that will fail the request when no ID is set.

@Velfi Velfi added the bug Something isn't working label Nov 7, 2022
@Velfi Velfi self-assigned this Nov 7, 2022
@rcoh
Copy link
Collaborator

rcoh commented Nov 7, 2022

we currently can do this for {httpLabel}: https://github.com/awslabs/smithy-rs/blob/b4f294c2770c58148c43411803330c26e369ec14/codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/generators/http/RequestBindingGenerator.kt#L246

I'd suggest adding a private trait Mandatory or something and then using the same technique to fail the request at serialization time

@Velfi Velfi changed the title Add S3 customization to prevent accidental data deletion for AbortMultiPartUpload requests with no ID Add S3 customization to prevent accidental data deletion for AbortMultipartUpload requests with no ID Nov 9, 2022
@jdisanti
Copy link
Collaborator

The fix for this was included in release-2022-12-14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants