Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to set 'policy' and 'policy_arns' in AssumeRoleProvider bu… #1892

Merged
merged 7 commits into from
Nov 3, 2022

Conversation

albe-rosado
Copy link
Contributor

Addresses awslabs/aws-sdk-rust#641

Motivation and Context

This change allows users to define inline IAM policies and/or set predefined policies (using their ARNs) for the role assumed with AssumeRoleProvider.

Description

Adds policy and policy_arns to AssumeRoleProvider builder.

Testing

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@albe-rosado albe-rosado marked this pull request as ready for review October 21, 2022 19:58
@albe-rosado albe-rosado requested review from a team as code owners October 21, 2022 19:58
Copy link
Collaborator

@jdisanti jdisanti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the contribution!

CHANGELOG.next.toml Outdated Show resolved Hide resolved
@jdisanti jdisanti enabled auto-merge (squash) November 3, 2022 20:07
@jdisanti jdisanti merged commit 8ba894b into smithy-lang:main Nov 3, 2022
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2024
…entialsProvider` builder (#3506)

Related PR: #1892

## Motivation and Context
This change allows users to define inline IAM policies and/or set
predefined policies (using their ARNs) with
`WebIdentityTokenCredentialsProvider`

## Description
Adds `policy` and `policy_arns` to `WebIdentityTokenCredentialsProvider`
builder.

## Testing

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: ysaito1001 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants