Honor the default trait
#1860
Labels
Comments
|
I think only the server needs to implement this. The clients aren't supposed to send the default value since changing the default is not a backwards breaking change. |
82marbag
added a commit
that referenced
this issue
Oct 19, 2022
Add support for the @default trait. Issue: #1860 Reference for the trait: https://awslabs.github.io/smithy/2.0/spec/type-refinement-traits.html Signed-off-by: Daniele Ahmed <[email protected]>
82marbag
added a commit
that referenced
this issue
Oct 20, 2022
Add support for the @default trait. Issue: #1860 Reference for the trait: https://awslabs.github.io/smithy/2.0/spec/type-refinement-traits.html Signed-off-by: Daniele Ahmed <[email protected]>
|
PR failing pending more info on smithy-lang/smithy#1456 |
82marbag
added a commit
that referenced
this issue
Nov 3, 2022
Add support for the @default trait. Issue: #1860 Reference for the trait: https://awslabs.github.io/smithy/2.0/spec/type-refinement-traits.html Signed-off-by: Daniele Ahmed <[email protected]>
82marbag
added
server
|
Leaving this open for the client implementation |
|
I believe the client does this correctly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Neither clients or servers are honoring the
defaulttrait from IDL v2. This trait affects serialization behavior of clients and servers.Note that as far as I know, awslabs/smithy does not yet provide protocol tests exercising this trait, so we may have to write our own and contribute them upstream.
The text was updated successfully, but these errors were encountered: