aws-smithy-query: bump to urlencoding v2.1 #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures look like permissions errors that are unrelated to the contents of this PR! |
|
do you mind adding a changelog entry on the off chance it helps debug some future issue? LGTM otherwise, thanks for doing this! |
|
Happy to add the changelog, but don't want to overwrite your merge! Ok to just push up the new commit, or are you already on it? |
|
oh you can just pull it down—I just clicked the merge button on Github (or
feel free to overwrite)
…On Mon, Apr 4, 2022 at 1:33 PM Nikhil Benesch ***@***.***> wrote:
Happy to add the changelog, but don't want to overwrite your merge! Ok to
just push up the new commit, or are you already on it?
—
Reply to this email directly, view it on GitHub
<#1301 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYKZ3QZFJNMY2PS3VO2KLVDNGZ5ANCNFSM5SPZBPDQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Perfect, pushed up the changelog entry! |
|
Well, I added an entry for smithy-rs. Do I also need to add an entry for aws-sdk-rust? It's not clear to me whether "aws-smithy-query" counts as an AWS SDK runtime crate or not. |
rcoh
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
urlencoding v2.1 is a SemVer-breaking change. We use
urlencodingin our own crates downstream, and we want to have only one copy ofurlencoding, so we needaws-smithy-queryto upgrade to.Description
Bumps
aws-smithy-queryfrom urlencoding v1.3 to urlencoding v2.1.Testing
CI coverage should be enough!
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.