Make rustls and native_tls client builder helpers dyn
#1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
|
rcoh
approved these changes
Feb 23, 2022
Comment on lines
+307
to
+322
| /// Connect to the service over HTTPS using Rustls using dynamic dispatch. | ||
| pub fn rustls(self) -> ClientBuilder<DynConnector, M, R> { | ||
| self.connector(DynConnector::new( | ||
| Adapter::builder().build(crate::conns::https()), | ||
| )) | ||
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "native-tls")] | ||
| impl<M, R> ClientBuilder<(), M, R> { | ||
| /// Connect to the service over HTTPS using the native TLS library on your platform. | ||
| pub fn native_tls( | ||
| self, | ||
| ) -> ClientBuilder<Adapter<hyper_tls::HttpsConnector<hyper::client::HttpConnector>>, M, R> { | ||
| self.connector(Adapter::builder().build(crate::conns::native_tls())) | ||
| /// Connect to the service over HTTPS using the native TLS library on your | ||
| /// platform using dynamic dispatch. | ||
| pub fn native_tls(self) -> ClientBuilder<DynConnector, M, R> { | ||
| self.connector(DynConnector::new( | ||
| Adapter::builder().build(crate::conns::native_tls()), | ||
| )) |
There was a problem hiding this comment.
I wonder if we should examples in these methods about how not to use them when required (basically including examples of custom HTTPS, or at least linking to them)
There was a problem hiding this comment.
Filed an issue for improving these docs overall: awslabs/aws-sdk-rust#469
|
A new generated diff is ready to view.
|
|
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes awslabs/aws-sdk-rust#467 which was caused by making the SDK clients use
DynConnectorin #1132.There's a bit of conflict here between smithy-rs and SDK use-cases. Developers using smithy-rs want the flexibility to use static dispatch on the client's connector, but the SDK does not need this. I'm opting to make the SDK use-case easy and convenient, and it should even work for most smithy-rs use-cases. Those who need to use static dispatch will need to manually construct an adapter (for example,
builder.connector(Adapter::builder().build(aws_smithy_client::conns::https()))) if the performance difference is a concern.I considered adding
rustls_staticandnative_tls_staticequivalents for static dispatch, but I thought those might cause confusion.Testing
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.