refactor(core-app-plane)!: replace BashJobRunner with ScriptJob #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujwalbukka
reviewed
Jul 31, 2024
tobuck-aws
approved these changes
Aug 1, 2024
This commit refactors the BashJobRunner construct into a more generic ScriptJob construct. It also introduces two new constructs, ProvisioningScriptJob and DeprovisioningScriptJob, which are wrappers around ScriptJob with predefined configurations for tenant provisioning and deprovisioning scenarios. The main changes include: - Rename BashJobRunner to ScriptJob and update related interfaces and properties - Add OutgoingEventDetailTypes interface to represent success and failure detail types - Introduce ProvisioningScriptJob and DeprovisioningScriptJob constructs - Update CoreApplicationPlane to use scriptJobs instead of jobRunnersList - Update integration tests and documentation accordingly This refactoring provides a more flexible and extensible approach for running arbitrary scripts in the application plane, while also simplifying the configuration for common tenant lifecycle management scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #73
Reason for this change
#73
Description of changes
This commit refactors the BashJobRunner construct into a more generic ScriptJob construct. It also introduces two new constructs, ProvisioningScriptJob and DeprovisioningScriptJob, which are wrappers around ScriptJob with predefined configurations for tenant provisioning and deprovisioning scenarios.
The main changes include:
This refactoring provides a more flexible and extensible approach for running arbitrary scripts in the application plane, while also simplifying the configuration for common tenant lifecycle management scenarios.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.