Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Decoding of the QueryParams #23

Closed
AbhiPartha opened this issue Dec 23, 2021 · 2 comments · Fixed by #24
Closed

Double Decoding of the QueryParams #23

AbhiPartha opened this issue Dec 23, 2021 · 2 comments · Fixed by #24
Labels
bug Something isn't working

Comments

@AbhiPartha
Copy link

What happened:

The code double decodes the query params resulting in malformed queryParam or altered queryParam.

What did you expect to have happen:

The queryParam to be return as such it was called.

How to reproduce this (as precisely and succinctly as possible):

Simply use the library and call with encoded queryParam and see the double decoding happening.

Anything else you think we should know?

The fix is in https://github.com/awslabs/cognito-at-edge/blob/main/index.js#L180
Removing the extra decoding might solve the issue.

Environment:

  • version of cognito-at-edge being used: 1.1.0
  • node version of code base which uses cognito-at-edge: 14x
@AbhiPartha AbhiPartha changed the title Double Decoding the QueryParams Double Decoding of the QueryParams Dec 23, 2021
@jeandek
Copy link
Contributor

jeandek commented Jan 3, 2022

Hi @AbhiPartha ,

Thanks for opening this issue and submitting a PR. I'm currently testing it and I'm observing some unexpected encoding differences between my test setup and another environment which uses the package. I'll keep you updated.

@jeandek jeandek added the bug Something isn't working label Jan 3, 2022
@jeandek jeandek linked a pull request Jan 5, 2022 that will close this issue
@jeandek
Copy link
Contributor

jeandek commented Jan 5, 2022

Merged and will be included in the next release.

@jeandek jeandek closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants