Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cache-Control headers to redirect responses #18

Closed
ineale2 opened this issue Oct 20, 2021 · 1 comment · Fixed by #19
Closed

Add Cache-Control headers to redirect responses #18

ineale2 opened this issue Oct 20, 2021 · 1 comment · Fixed by #19
Labels
bug Something isn't working

Comments

@ineale2
Copy link
Contributor

ineale2 commented Oct 20, 2021 •
edited
Loading

What would you like to be added:

  • Set cache-control and pragma headers to the redirect responses

Why is this needed:

  • When the Authenticator redirects to Cognito or with the set-cookies header, some browsers (IE11 in specific) cache the 302 response as no cache-control headers are set.
  • When subsequent requests come (with valid cookies), IE11 will retrieve the cached 302 response and get stuck in a redirect loop
@ineale2 ineale2 mentioned this issue Oct 20, 2021
Merged
@jeandek jeandek added the bug Something isn't working label Oct 22, 2021
@jeandek jeandek linked a pull request Jan 7, 2022 that will close this issue
Add cache-control & pragma headers to redirect responses #19
Merged
@jeandek
Copy link
Contributor

jeandek commented Jan 7, 2022

Merged and will be included in next release.

@jeandek jeandek closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cache-control & pragma headers to redirect responses ineale2/cognito-at-edge
2 participants
@jeandek @ineale2