Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smithy update to 1.26.1 causes protocol test to fail #665

Closed
jbelkins opened this issue Nov 2, 2022 · 0 comments
Closed

Smithy update to 1.26.1 causes protocol test to fail #665

jbelkins opened this issue Nov 2, 2022 · 0 comments
Assignees
@epau
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@jbelkins
Copy link
Contributor

jbelkins commented Nov 2, 2022

Describe the bug

The Smithy project changed the way empty queries are to be serialized here. This change was introduced in Smithy 1.26.1.

This change in intended behavior broke a corresponding protocol test in the Swift project.

Expected Behavior

All protocol tests pass.

Current Behavior

One protocol test fails:

smithy-swift/Packages/SmithyTestUtil/Sources/RequestTestUtil/HttpRequestTestBase.swift:342: error: QueryListsRequestTest.testEc2EmptyQueryLists : XCTAssertTrue failed - expected query name value pair not found: ListArg:
Optional("")

Reproduction Steps

Run CI on any branch forked from main. Observe CI jobs fail with a failed test.

Possible Solution

Change the Swift test to match expected Smithy behavior.

Additional Information/Context

No response

AWS SWIFT SDK version used

main branch

Compiler and Version used

Latest

Operating System and version

All are affected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epau epau

Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbelkins @epau