Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuntimeComponents should be re-exported #862

Closed
jdisanti opened this issue Aug 4, 2023 · 4 comments
Closed

RuntimeComponents should be re-exported #862

jdisanti opened this issue Aug 4, 2023 · 4 comments
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@jdisanti
Copy link
Contributor

jdisanti commented Aug 4, 2023

RuntimeComponents are required in order to implement custom interceptors, and they're not currently re-exported by the SDK crates.
@jdisanti jdisanti added the bug This issue is a bug. label Aug 4, 2023
@jdisanti
Copy link
Contributor Author

jdisanti commented Aug 4, 2023

PR to fix this: smithy-lang/smithy-rs#2904

@jdisanti jdisanti added p2 This is a standard priority issue pr/needs-review This PR needs a review from a Member. pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed pr/needs-review This PR needs a review from a Member. labels Aug 4, 2023
@jdisanti
Copy link
Contributor Author

This has been fixed with the August 23rd release.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@rcoh
Copy link
Contributor

rcoh commented Nov 7, 2023

fix verified

@rcoh rcoh removed the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdisanti @rcoh