-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bearer authentication and SSO token providers #703
Comments
Is there a workaround for this? SSO sessions are becoming increasingly more popular. If not, any hints on what changes are necessary to have this implemented? |
We're working on this and we expect it to be complete at or before GA. I can't give a date for GA at this time. |
Our team has configured AWS CLI using |
My guess is it's related to profile-file reparsing—we "fixed" a "bug" where we were reloading the profile file multiple times which caused this to work by coincidence. However, no other SDKs have this behavior so for consistency, we altered the SDK to parse the config file a single time. I would expect that this works once, but maybe fails later? Or it works if you run Some debug logs would also be helpful here. |
We're using it in a CLI tool right now. So I'm doing |
https://docs.aws.amazon.com/sdk-for-rust/latest/dg/logging.html just be careful to redact any sensitive data prior to sending |
cc @ysaito1001, I wonder if this is related to credentials caching changes. If you're preloading this doesn't seem to be related to the profile parse issue. |
Before:
After:
Sidenote: there should be an easy way to automatically redact sensitive data. |
do you use |
ah! I found it—are you using |
Nope.
Yep, that fixed it. Would've been nice to have a better error message or a mention in the changelogs. |
yep I'm fixing the error as we speak, new error:
|
@rcoh We also ran into this error:
|
any update? |
Sorry for the long delay in providing an update here. I'm working on adding this support now. It'll take a while, so I appreciate everyone's patience. |
What's the timeline on this? This sso nonsense has been broken in aws sdks across the board for wayy too long |
work is ongoing: smithy-lang/smithy-rs#2917 |
First of all, thanks for your hard work, this feature is highly appreciated! Since the PR has been merged, do you have an ETA for the next release? Thanks |
Just to clarify, for that PR, it's making the existing credentials provider work with the latest CLI. It's not adding SSO token support to the AWS config/profile files (e.g., We should be releasing in the next 2-3 weeks. |
This also appears to be broken with Cloud9 using AWS managed temporary credentials. $ cargo lambda deploy |
This was resolved in error. Re-opening. The config/profile file support and token provider chains still need to be implemented. |
For people just looking for a workaround to be able to use
This is a snippet that I use from my [dependencies]
aws-config = { version="0.57.1" , features = ["sso"]}
aws-sdk-sts = "0.35.0" And these are the changes I made to my (anonymised) --- config.old 2023-11-14 21:39:14
+++ config 2023-11-14 21:39:32
@@ -1,10 +1,8 @@
[default]
-sso_session = s0
sso_account_id = 87654321098
sso_role_name = AdministratorAccess
region = eu-north-1
output = json
-[sso-session s0]
sso_start_url = https://d-deadbeef.awsapps.com/start#
sso_region = eu-north-1
sso_registration_scopes = sso:account:access Hopefully, teaching |
Any timeline for this being implemented and released? |
Just ran into this, it would be great if this was resolved soon. In the meantime, here is an example of my working
To deploy the lambda:
But the profile and region are optional in that command given the above config. |
Can't give a timeline, but I'm picking up work on this again. Hopefully soon. |
The January 25th release of the SDK includes support for I'll continue working on SSO bearer token auth to support CodeCatalyst. |
Thanks a lot for this! I will check it out soon. |
Yeah, updated. |
The bearer token support went out in yesterday's release. |
Comments on closed issues are hard for our team to see. |
Describe the feature
Add support for bearer-token authentication &
sso-session
Use Case
these changes are required to support AWS Code Catalyst and the
smithy.api#httpBearerAuth
traitProposed Solution
No response
Other Information
No response
Acknowledgements
A note for the community
Community Note
The text was updated successfully, but these errors were encountered: