Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize roots #1171

Open
1 of 2 tasks
flisky opened this issue Jul 11, 2024 · 1 comment
Open
1 of 2 tasks

customize roots #1171

flisky opened this issue Jul 11, 2024 · 1 comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@flisky
Copy link

flisky commented Jul 11, 2024

Describe the feature

There're three ways in hyper-rustls to customize roots:

  • rustls-native-certs
  • webpki-roots
  • rustls-platform-verifier

aws-smithy-experimental only uses rustls-native-certs, but rustls-native-certs doesn't work on ios & android. And there's no way to customize?

refer: #575

Use Case

upgrade to hyper 1.x and use aws-sdk on mobile platforms

Proposed Solution

Add more feature flags to choose cert providers?

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@flisky flisky added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 11, 2024
@ysaito1001
Copy link
Collaborator

Hi @flisky, thank you for submitting an enhancement request.

We are aware of the need to configure the roots and will ensure that is indeed configurable as we roll out hyper 1.x.

Note that when we do roll it out, it could be that configuration is achieved by customizing an HttpConnector, and what we provide might be documentation in that case.

@ysaito1001 ysaito1001 removed the needs-triage This issue or PR still needs to be triaged. label Jul 15, 2024
@jmklix jmklix added the p2 This is a standard priority issue label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants