-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apparent contradiction between aws-smithy-types and generated code in aws-sdk-ec2 #1123
Comments
This is a case of unfortunate naming. In the EC2 smithy model,
Which is just a smithy integer:
We don't use Will they? 🤷♀️ Still, we must be prepare for that possibility. Does that clear things up for you? |
I think it was for two reasons:
Code written against the |
Leaving this open to fix the docs. |
Summarising to make sure I've understood correctly:
Does that sound about right? |
You got it! |
Describe the issue
Hello! I was reading through some of the generated code in the
aws-sdk-ec2
crate and stumbled upon this:aws-smithy-types
has this enum:Note the remark that
NegInt
is supposed to always be negative (and that there is no variant for a signed integer that may be either positive or negative).However, in the generated code in
aws-sdk-ec2
, insrc/protocol_serde/shape_accelerator_count_request.rs
(the first serializer) appears to pass in values that are unlikely to be negative.So... what's going on here? E.g.
NegInt
is actually routinely being used for all signed integers in practice, and the name or at least docs should be updated?Links
N/A
The text was updated successfully, but these errors were encountered: