Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Rust 2021 edition #414

Closed
calavera opened this issue Feb 9, 2022 · 2 comments · Fixed by #501
Closed

Migrate to Rust 2021 edition #414

calavera opened this issue Feb 9, 2022 · 2 comments · Fixed by #501

Comments

@calavera
Copy link
Contributor

calavera commented Feb 9, 2022

There were some issues migrating to 2021 edition. I think we should address the problems and move all the crates to the 2021 editions.
@nmoutschen
Copy link
Contributor

Is there any compelling reason to move to 2021 at the moment?

Currently, the AWS SDK is on 2018 with a MSRV of 1.54.0, so I'd personally prefer to stay there for compatibility reason.

@brainstorm
Copy link

smithy-lang/smithy-rs#1388

@calavera calavera mentioned this issue Jul 17, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Rust edition to 2021 awslabs/aws-lambda-rust-runtime
3 participants
@calavera @brainstorm @nmoutschen