-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema-registry-kafkaconnect-converter artifact is huge #156
Comments
Kafka converters are packaged as ZIPs or fat JARs to be able to install it on connectors. Reference |
I agree with you. Or did I miss something and you can deploy this converter separately and still reference it from another connector? |
We package it as a converter to provide convenience to users who don't want to do it separately. However, I do see value in separating the library and the converter part of it to support use-cases where users want to package it themselves. Thanks for highlighting this issue! Does it help if we separate the converter code into a separate module? I will also explore if there are simpler alternatives. |
I think that would solve our use-case yes. Thanks for considering. |
I do have a similar use case, we have imported the |
Ideally, Connectors only work with Schema and Struct types directly within the Connect API, and not import converters. Can you explain the use case more? If you need other POJO types, then those should be mapped to Struct objects, not a specific binary format |
This was the easiest workflow in our deployment model. Hence why we opted for this. |
I'll also add to this that amazon-kinesis-producer has also pulled this into itself as a dependency and has made it so this library cannot be easily excluded (both IKinesisProducer and KinesisProducer have direct dependencies and the only way to exclude the Glue stuff is to stub out the classes). |
The
schema-registry-kafkaconnect-converter
artifact is a whopping 55Mb on mavencentral. I see it's a shaded fat-jar.Any specific reason for this? The
schema-registry-serde
is packaged nicely.The text was updated successfully, but these errors were encountered: