Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow duplicate dimension sets #83

Closed
markkuhn opened this issue Aug 9, 2022 · 2 comments · Fixed by #85
Closed

Disallow duplicate dimension sets #83

markkuhn opened this issue Aug 9, 2022 · 2 comments · Fixed by #85
Assignees
@Stephen-Bao
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@markkuhn
Copy link
Contributor

markkuhn commented Aug 9, 2022 •
edited
Loading

Related issues:

Currently duplicate dimension sets are being allowed.
Example:

metrics.put_dimensions({"Region": "us-east-1"})
metrics.put_dimensions({"Region": "us-east-2"})

This creates:

"Dimensions": [
  [
    "LogGroup",
    "ServiceName",
    "ServiceType",
    "Region"
  ],
  [
    "LogGroup",
    "ServiceName",
    "ServiceType",
    "Region"
  ]
]

When it should be:

"Dimensions": [
  [
    "LogGroup",
    "ServiceName",
    "ServiceType",
    "Region"
  ]
]
@markkuhn markkuhn added bug Something isn't working good first issue Good for newcomers labels Aug 9, 2022
@gordonpn
Copy link
Member

Should there be an issue for the dotnet library as well?

@markkuhn
Copy link
Contributor Author

markkuhn commented Aug 10, 2022 •
edited
Loading

@gordonpn It is indeed an issue in the dotnet library as well. Creating an issue for it.

@gordonpn gordonpn mentioned this issue Aug 10, 2022
Closed
@Stephen-Bao Stephen-Bao self-assigned this Aug 12, 2022
@markkuhn markkuhn mentioned this issue Aug 12, 2022
Closed
@Stephen-Bao Stephen-Bao mentioned this issue Aug 15, 2022
Merged
@markkuhn markkuhn linked a pull request Sep 15, 2022 that will close this issue
Disallow duplicate dimension sets #85
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stephen-Bao Stephen-Bao

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow duplicate dimension sets awslabs/aws-embedded-metrics-python
3 participants
@gordonpn @markkuhn @Stephen-Bao