Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES Module and Validator package #140

Closed
thantos opened this issue Nov 19, 2022 · 3 comments
Closed

ES Module and Validator package #140

thantos opened this issue Nov 19, 2022 · 3 comments
Assignees
@markkuhn
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@thantos
Copy link

thantos commented Nov 19, 2022

Are there plans to publish an ESM and tree shaken version of the package?

EMF is ~300kb without compression with 200kb just for the new validator dependency, most of which is not being used.

With SDK V3 being supported in Node18 on Lambda, EMF is now 90% of my bundle.
@markkuhn markkuhn added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 19, 2022
@sam-goodwin
Copy link

Any update on this? The Node community is bundle conscious and a metric client adding 200KB is excessive. Any plan to fix?

@markkuhn markkuhn self-assigned this Jan 25, 2023
@markkuhn
Copy link
Contributor

Thanks for reporting this.
The validator dependency has been removed.

@sam-goodwin
Copy link

Happy to see this roll out! To pile on, I'm curious if there are any plans to include EMF in the lambda runtime image? Seems like one of those super common things everyone needs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markkuhn markkuhn

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thantos @sam-goodwin @markkuhn