Debug Improvements #938
Merged
Debug Improvements #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
approved these changes
Nov 18, 2025
TingDaoK
reviewed
Nov 18, 2025
| /* The setup function will be run before every test */ | ||
| @Before | ||
| public void setup() { | ||
| System.out.println("[TEST START] " + testName.getMethodName()); |
Contributor
There was a problem hiding this comment.
https://github.com/awslabs/aws-crt-java/actions/runs/19476392289/job/55739151489?pr=938#step:4:2041
Do we really want all of those print out in the log? Is there an example about this helping debugging?
Contributor
Author
There was a problem hiding this comment.
There are times when tests fail but there is no record of which test from a class of tests was the one that failed. I've seen it most when tests time out and logs need to be truncated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various debugging improvements
Log test names when they run
More explicit logging to track refCount manipulation in CrtResource
decRef logging descriptions for overwritten close() functions and for staticClose
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.