Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apigateway: "methodResponses" is missing from MethodOptions #905

Closed
eladb opened this issue Oct 11, 2018 · 6 comments · Fixed by #2960 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

apigateway: "methodResponses" is missing from MethodOptions #905

eladb opened this issue Oct 11, 2018 · 6 comments · Fixed by #2960 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved.

Comments

@eladb
Copy link
Contributor

eladb commented Oct 11, 2018

For some reason, methodResponses is missing from the API Gateway Method construct.
@eladb eladb added the feature label Oct 14, 2018
@rix0rrr rix0rrr added feature-request A feature should be added or improved. and removed feature-request A feature should be added or improved. feature labels Nov 6, 2018
@debora-ito debora-ito added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Nov 7, 2018
@john-shaskin
Copy link
Contributor

Is anyone working on this? I was thinking of picking this up.

@eladb
Copy link
Contributor Author

eladb commented Dec 23, 2018

@john-shaskin go ahead, it's all yours! ❤️

@rix0rrr rix0rrr added the gap label Jan 4, 2019
@john-shaskin
Copy link
Contributor

Getting a PR together for this shortly.

@john-shaskin
Copy link
Contributor

Addressed in #1572

@divyachaudhary2
Copy link

Hi is there any update on when this will be deployed?

@john-shaskin
Copy link
Contributor

The PR is awaiting a second review. I’ll do some prodding.

@julienlepine julienlepine mentioned this issue Jun 20, 2019
Merged
4 tasks
eladb pushed a commit that referenced this issue Jun 27, 2019
@julienlepine
feat(aws-apigateway): expand RestApi support to models, parameters an…
12e6380 
…d validators (#2960)

Fixes #905: "apigateway: "methodResponses" is missing from MethodOptions"
Fixes #1695: apigateway: missing support for models
Fixes #727: API Gateway: improve API for request parameters and responses
Fixes #723: API Gateway: missing features
Fixes #2957: RestApi to use logical id as a name for APIs instead of name of current construct
Adds support for JsonSchema in Model
Aligns Model to the PhysicalName convention.
No breaking change, documentation updated
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
This was referenced Dec 13, 2019
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-apigateway): expand RestApi support to models, parameters and validators
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
5 participants
@debora-ito @rix0rrr @eladb @divyachaudhary2 @john-shaskin