-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(events): correct token resolution in RuleTargetInput #3127
Conversation
@@ -148,7 +148,7 @@ class FieldAwareEventInput extends RuleTargetInput { | |||
} | |||
|
|||
public resolveToken(t: Token, _context: IResolveContext) { | |||
if (!isEventField(t)) { return t; } | |||
if (!isEventField(t)) { return Token.asString(t); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it used to inherit a working toString()
. Implementing that on the Token would also have worked. I think I would feel safer if we did that... but that can wait until we uncover a new failing case maybe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it have worked with token encoded as numbers?
Fixes #3119
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license