Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs: the default Amazon Linux generation should be v2 #3005

Closed
1 of 5 tasks
hencrice opened this issue Jun 21, 2019 · 0 comments · Fixed by #3009 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7

Comments

@hencrice
Copy link
Contributor

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.
  • What is the current behavior?
    Current default generation is Amazon Linux v1

  • What is the expected behavior (or behavior of feature suggested)?
    The expected behavior is that by default, CDK should select Amazon Linux v2 instead of Amazon Linux v1.

  • What is the motivation / use case for changing the behavior or adding this feature?
    This change make the CDK consistent with the recommendation we give customers: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html

  • Please tell us about your environment:
    N/A

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)
    N/A

eladb pushed a commit that referenced this issue Jun 24, 2019
This change make CDK consistent with the recommendataion we give customers: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html. This closes #3005.

BREAKING CHANGE: Previously, the default generation is conditionally set to Amazon Linux v1 if `hardwareType` was `STANDARD`. Now it always defaults to Amazon Linux v2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment