Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs: Rename hwType in EcsOptimizedAmiProps interface to hardwareType #2896

Closed
hencrice opened this issue Jun 17, 2019 · 2 comments · Fixed by #2916 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

ecs: Rename hwType in EcsOptimizedAmiProps interface to hardwareType #2896

hencrice opened this issue Jun 17, 2019 · 2 comments · Fixed by #2916 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@hencrice
Copy link
Contributor

As title suggested
@hencrice hencrice added the feature-request A feature should be added or improved. label Jun 17, 2019
@NGL321
Copy link
Contributor

NGL321 commented Jun 18, 2019

Hi Yenlin, thank you for following the contribution guidelines and creating an issue for your changes!

However, the purpose behind that rule is to justify the changes you are making.
Please add some content here to explain why you think that 'hwType' needs to be renamed!

@NGL321 NGL321 added @aws-cdk/aws-ecs Related to Amazon Elastic Container response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jun 18, 2019
@NGL321 NGL321 assigned NGL321 and unassigned NGL321 Jun 18, 2019
@hencrice
Copy link
Contributor Author

hencrice commented Jun 18, 2019 •
edited
Loading

Hey Noah,

This suggestion came from an ECS-internal API review. I'm following the guideline here for contribution: https://github.com/awslabs/aws-cdk/blob/master/CONTRIBUTING.md and that was why I created this issue.

@hencrice hencrice mentioned this issue Jun 18, 2019
Merged
3 tasks
rix0rrr pushed a commit that referenced this issue Jun 19, 2019
@hencrice @rix0rrr
refactor(ecs): rename hwType to hardwareType (#2916)
1aa0589 
This change spells out the previously abbreviated `hwType` into `hardwareType` and it closes #2896.

BREAKING CHANGE: 

* **ecs**: the property that specifies the type of EC2 AMI optimized for ECS was renamed to `hardwareType` from `hwType`.
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 13, 2019
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(ecs): rename hwType in EcsOptimizedAmiProps to `hardware…
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/cdk from 0.24.1 to 0.35.0 MechanicalRock/account-reaper
2 participants
@hencrice @NGL321