Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Remove stack rename support #2819

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Jun 11, 2019

BREAKING CHANGE: The CLI no longer accepts --rename, and the stack
names are now immutable on the stack artifact.

Fixes #2670


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

BREAKING CHANGE: The CLI no longer accepts `--rename`, and the stack
                 names are now immutable on the stack artifact.

Fixes #2670
@RomainMuller RomainMuller requested a review from a team as a code owner June 11, 2019 11:20
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to run all toolkit integration tests (see the README file in the integ tests directory for instructions on how to run tests against a repo)

@RomainMuller
Copy link
Contributor Author

@eladb reporting success from all the integration tests in the suite, without changes.

@RomainMuller RomainMuller merged commit 0f30e39 into master Jun 11, 2019
@RomainMuller RomainMuller deleted the rmuller/remove-cli-renames branch June 11, 2019 14:24
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing stack renaming support from the toolkit
3 participants