Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): LoadBalancedFargateService - allow specifying containerName and role #2764

Merged
merged 2 commits into from
Jun 13, 2019
Merged

feat(ecs-patterns): LoadBalancedFargateService - allow specifying containerName and role #2764

merged 2 commits into from
Jun 13, 2019

Conversation

DavidChristiansen
Copy link
Contributor

@DavidChristiansen DavidChristiansen commented Jun 5, 2019 •
edited
Loading

Implementation of execution tests, task role and container name overrides + tests

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@DavidChristiansen DavidChristiansen requested a review from a team as a code owner June 5, 2019 23:50
@DavidChristiansen DavidChristiansen changed the title davidchristiansen/LoadBalancedFargateService-ContainerNameAndRoleOverrides **feat** (ecs-patterns) LoadBalancedFargateService-ContainerNameAndRoleOverrides Jun 5, 2019
@DavidChristiansen DavidChristiansen changed the title **feat** (ecs-patterns) LoadBalancedFargateService-ContainerNameAndRoleOverrides feat (ecs-patterns) LoadBalancedFargateService-ContainerNameAndRoleOverrides Jun 5, 2019
@DavidChristiansen DavidChristiansen force-pushed the davidchristiansen/LoadBalancedFargateService-ContainerNameAndRoleOverrides branch from 10bf981 to b0fa386 Compare June 6, 2019 22:20
@DavidChristiansen DavidChristiansen mentioned this pull request Jun 7, 2019
Closed
@DavidChristiansen DavidChristiansen force-pushed the davidchristiansen/LoadBalancedFargateService-ContainerNameAndRoleOverrides branch from b0fa386 to 2b5cdba Compare June 10, 2019 23:10
@DavidChristiansen
davidchristiansen/LoadBalancedFargateService-ContainerNameAndRoleOver…
b094343 
…ridesImplemenation of execution tests, task role andcontainer name overrides + tests
@DavidChristiansen DavidChristiansen force-pushed the davidchristiansen/LoadBalancedFargateService-ContainerNameAndRoleOverrides branch from 2b5cdba to b094343 Compare June 12, 2019 20:57
@DavidChristiansen DavidChristiansen mentioned this pull request Jun 12, 2019
Closed
DavidChristiansen
DavidChristiansen commented Jun 13, 2019
View reviewed changes
Copy link
Contributor Author

@DavidChristiansen DavidChristiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review

@eladb eladb changed the title feat (ecs-patterns) LoadBalancedFargateService-ContainerNameAndRoleOverrides feat(ecs-patterns): LoadBalancedFargateService - allow specifying containerName and role Jun 13, 2019
@eladb eladb merged commit df12197 into aws:master Jun 13, 2019
@DavidChristiansen DavidChristiansen deleted the davidchristiansen/LoadBalancedFargateService-ContainerNameAndRoleOverrides branch June 13, 2019 23:53
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
This was referenced Dec 12, 2019
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leepa leepa leepa requested changes

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidChristiansen @leepa @eladb