feat(event-targets): add support for fargate/awsvpc tasks #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target is "enhanced" using an AwsCustomResource calling `CloudWatchEvents.putTargets`. Fix wrong reference to container name in `containerOverrides` (must be `name`). BREAKING CHANGE: `targets.EcsEc2Task` renamed to `targets.EcsTask`
rix0rrr
reviewed
Jun 3, 2019
packages/@aws-cdk/aws-events-targets/lib/ecs-task-properties.ts
Outdated
Show resolved
Hide resolved
| const assignPublicIp = subnetSelection.subnetType === ec2.SubnetType.Private ? 'DISABLED' : 'ENABLED'; | ||
|
|
||
| new cloudformation.AwsCustomResource(this.taskDefinition, 'PutTargets', { | ||
| onUpdate: { // We don't need an onDelete here because the target will be owned by CF anyway |
There was a problem hiding this comment.
This is confusing to me. Why no onCreate?
There was a problem hiding this comment.
onCreate defaults to onUpdate
There was a problem hiding this comment.
There was a problem hiding this comment.
I have to say I have mixed feelings about this implementation... but I guess this is the point of the CDK :)
There was a problem hiding this comment.
Which implementation, AwsCustomResource or this ECS target?
There was a problem hiding this comment.
Yes, the fact that it is using a custom resource to achieve its goal.
This was referenced Aug 22, 2019
2 tasks
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target is "enhanced" using an AwsCustomResource calling
CloudWatchEvents.putTargets.Fix wrong reference to container name in
containerOverrides(must bename).BREAKING CHANGE:
targets.EcsEc2Taskrenamed totargets.EcsTaskPull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.