Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cdk): fix cdk error on Windows #2660

Merged
merged 2 commits into from
May 28, 2019

Conversation

Iamz
Copy link
Contributor

@Iamz Iamz commented May 28, 2019

Fix an error when running any cdk command on Windows caused by '/' in ts-node path.

Fixes #2657


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
    • Manual test on Linux/Windows
      • cd packages/aws-cdk
      • mkdir temp && cd temp
      • ../bin/cdk init --language typescript
      • cdk synth # Resources: {}
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Fix an error when running any cdk command on Windows caused by '/' in ts-node path.
@Iamz Iamz requested a review from a team as a code owner May 28, 2019 15:08
@eladb
Copy link
Contributor

eladb commented May 28, 2019

Can you please search for all usages of ts-node. I believe this is another one, but just to make sure I didn't forget anything.

@Iamz
Copy link
Contributor Author

Iamz commented May 28, 2019

That's the only one I found as well. I'll change that too and push again.

@eladb eladb merged commit 5fe0af5 into aws:master May 28, 2019
@Iamz Iamz deleted the iamz/fix-typescript-template-for-windows branch May 29, 2019 02:32
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use cdk command on Windows
2 participants