fix(core): Correctly search for loaded modules in node 12 #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 12 has corrected how the require.resolve function applied un-documented behavior, so that it is needed to make relative search paths explicit (./). The new approach should be backwards-compatible. Related: nodejs/node#27583
rix0rrr
approved these changes
May 23, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 has corrected how the require.resolve function applied un-documented behavior, so
that it is needed to make relative search paths explicit (./). The new approach should be
backwards-compatible.
Related: nodejs/node#27583
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.