Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-apigateway): add support for UsagePlan, ApiKey, UsagePlanKey #2564

Merged
merged 30 commits into from
May 28, 2019

Conversation

orangewise
Copy link
Contributor


#723

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@orangewise orangewise requested a review from a team as a code owner May 16, 2019 12:47
@orangewise orangewise changed the title Orangewise/usage 723 feat(aws-apigateway): add support for UsagePlan, ApiKey, UsagePlanKey May 16, 2019
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial feedback on README

packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/README.md Outdated Show resolved Hide resolved
Ronald Luitwieler added 3 commits May 17, 2019 08:55
@orangewise
Copy link
Contributor Author

Hi @eladb, thanks for reviewing. I've made a couple of changes you suggested. Could not wrap my head around the addStage stuff. Maybe you can help me out a little?

@rix0rrr rix0rrr self-assigned this May 20, 2019
packages/@aws-cdk/aws-apigateway/lib/api-key.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/restapi.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/usage-plan.ts Outdated Show resolved Hide resolved
packages/aws-cdk/aws-cdk Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/api-key.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/usage-plan.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigateway/lib/usage-plan.ts Outdated Show resolved Hide resolved
@orangewise
Copy link
Contributor Author

Hi @rix0rrr, I've updated the PR, maybe you can check when you have time.

Thanks!

@rix0rrr
Copy link
Contributor

rix0rrr commented May 24, 2019

Sorry, this has slipped my attention. Could you merge from master to make sure this still passes linter checks? We've added a couple in the mean time and I'd hate for a merge to break the build.

@orangewise
Copy link
Contributor Author

Np, I've pulled in the changes...

@rix0rrr rix0rrr merged commit 203f114 into aws:master May 28, 2019
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants