Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codedeploy): change the load balancer API in server Deployment Gr… #2548

Merged
merged 1 commit into from
May 16, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented May 15, 2019

…oup.

BREAKING CHANGE: the type of the loadBalancer property in ServerDeploymentGroupProps has been changed.

Fixes #2449


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested a review from eladb May 15, 2019 14:15
@skinny85 skinny85 requested review from RomainMuller and a team as code owners May 15, 2019 14:15
packages/@aws-cdk/aws-codedeploy/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to publish a "deprecation version" of the codedeploy-api package. It should just include a README file with no types that says that the package is deprecated.

packages/@aws-cdk/aws-codedeploy/README.md Outdated Show resolved Hide resolved
@skinny85 skinny85 force-pushed the feature/codedeploy-lb-api-changes branch from 42023c0 to ad62333 Compare May 15, 2019 15:00
…oup.

BREAKING CHANGE: the type of the `loadBalancer` property in ServerDeploymentGroupProps has been changed.

Fixes aws#2449
@skinny85 skinny85 force-pushed the feature/codedeploy-lb-api-changes branch from ad62333 to d1cfd63 Compare May 15, 2019 15:11
@skinny85 skinny85 merged commit 8e05d49 into aws:master May 16, 2019
@skinny85 skinny85 deleted the feature/codedeploy-lb-api-changes branch May 16, 2019 08:04
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of aws-codedeploy-api and asCodeDeployLoadBalancer
4 participants