-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codedeploy): change the load balancer API in server Deployment Gr… #2548
Merged
skinny85
merged 1 commit into
aws:master
from
skinny85:feature/codedeploy-lb-api-changes
May 16, 2019
Merged
fix(codedeploy): change the load balancer API in server Deployment Gr… #2548
skinny85
merged 1 commit into
aws:master
from
skinny85:feature/codedeploy-lb-api-changes
May 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
May 15, 2019
eladb
reviewed
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to publish a "deprecation version" of the codedeploy-api package. It should just include a README file with no types that says that the package is deprecated.
skinny85
force-pushed
the
feature/codedeploy-lb-api-changes
branch
from
May 15, 2019 15:00
42023c0
to
ad62333
Compare
…oup. BREAKING CHANGE: the type of the `loadBalancer` property in ServerDeploymentGroupProps has been changed. Fixes aws#2449
skinny85
force-pushed
the
feature/codedeploy-lb-api-changes
branch
from
May 15, 2019 15:11
ad62333
to
d1cfd63
Compare
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oup.
BREAKING CHANGE: the type of the
loadBalancer
property in ServerDeploymentGroupProps has been changed.Fixes #2449
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.