Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codecommit): add a Repository.fromRepositoryName() method #2515

Merged
merged 1 commit into from
May 10, 2019
Merged

fix(codecommit): add a Repository.fromRepositoryName() method #2515

merged 1 commit into from
May 10, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented May 9, 2019

Fixes #2514

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested review from RomainMuller and a team as code owners May 9, 2019 23:16
@skinny85 skinny85 force-pushed the fix/codecommit-from-repo-name branch from 0dff101 to 1eab804 Compare May 10, 2019 17:27
@skinny85
Copy link
Contributor Author

Added some tests, because I felt bad.

@skinny85 skinny85 merged commit 6fc3718 into aws:master May 10, 2019
@skinny85 skinny85 deleted the fix/codecommit-from-repo-name branch May 10, 2019 18:35
eladb
eladb reviewed May 13, 2019
View reviewed changes
packages/@aws-cdk/aws-codecommit/lib/repository.ts

return new Import(scope, id);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change these to free floating functions.

SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
@skinny85 @SanderKnape
fix(codecommit): add a Repository.fromRepositoryName() method. (aws#2515
ebf56df 
)

Fixes aws#2514
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 13, 2019
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb left review comments

@rix0rrr rix0rrr rix0rrr approved these changes

@RomainMuller RomainMuller Awaiting requested review from RomainMuller

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CodeCommit's Repository is missing a fromRepositoryName method
4 participants
@skinny85 @rix0rrr @eladb @NGL321