Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): allow to specify log retention for aws log driver #2511

Merged
merged 1 commit into from
May 10, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented May 9, 2019

Allow to specify a log retention when using the AWS Log Driver with an automatically created group.

Also add tests for the driver.

Note: this can of course already be achieved today by first creating the log group and then passing it to the driver, but I think it's a better user experience to allow to specify the retention directly.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Allow to specify a log retention when using the AWS Log Driver with an automatically created group.

Also add tests for the driver.
@jogold jogold requested review from SoManyHs and a team as code owners May 9, 2019 10:23
@jogold
Copy link
Contributor Author

jogold commented May 9, 2019

TO BE DISCUSSED: What should be the default? Never expire like in Lambda (this PR's proposal), 365 like it is right now, 731 like the default for a new log group? This needs uniformity...

@rix0rrr rix0rrr merged commit 1feda0c into aws:master May 10, 2019
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
Allow to specify a log retention when using the AWS Log Driver with an automatically created group.

Also add tests for the driver.
@jogold jogold deleted the ecs-log-retention branch June 13, 2019 13:19
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants