-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-ecs): set memoryReservationMiB in LoadBalancedEcsService #2463
Merged
rix0rrr
merged 1 commit into
aws:master
from
piradeepk:fix-loadbalancedecsfargateservice
May 6, 2019
Merged
fix(aws-ecs): set memoryReservationMiB in LoadBalancedEcsService #2463
rix0rrr
merged 1 commit into
aws:master
from
piradeepk:fix-loadbalancedecsfargateservice
May 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoManyHs
changed the title
fix(aws-ecs): memoryReservationLimit not being set in LoadBalancedEcsService
fix(aws-ecs): memoryReservation not being set in LoadBalancedEcsService
May 2, 2019
SoManyHs
suggested changes
May 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you add a test in test/test-l3s.ts
?
Thanks!
SoManyHs
changed the title
fix(aws-ecs): memoryReservation not being set in LoadBalancedEcsService
fix(aws-ecs): set memoryReservation in LoadBalancedEcsService
May 2, 2019
SoManyHs
changed the title
fix(aws-ecs): set memoryReservation in LoadBalancedEcsService
fix(aws-ecs): set memoryReservationMiB in LoadBalancedEcsService
May 2, 2019
piradeepk
force-pushed
the
fix-loadbalancedecsfargateservice
branch
from
May 3, 2019 04:31
b3ca5be
to
cd3b105
Compare
Added and updated a test. |
SoManyHs
reviewed
May 3, 2019
SoManyHs
approved these changes
May 3, 2019
piradeepk
force-pushed
the
fix-loadbalancedecsfargateservice
branch
from
May 3, 2019 21:37
3e1295c
to
a9fdf7f
Compare
Squashed commits |
SanderKnape
pushed a commit
to SanderKnape/aws-cdk
that referenced
this pull request
May 14, 2019
) Previously, only `memoryLimitMiB` was being set in the constructor. This would cause an unexpected validation error when a LoadBalancedEcsService was instantiated with `memoryReservationMiB` only specified. This fix correctly sets both fields. Fixes aws#2263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only
memoryLimitMiB
was being set in the constructor. This would cause an unexpected validation error when a LoadBalancedEcsService was instantiated withmemoryReservationMiB
only specified. This fix correctly sets both fields.Fixes #2263
Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.