Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-ecs): set memoryReservationMiB in LoadBalancedEcsService #2463

Merged
merged 1 commit into from
May 6, 2019

Conversation

piradeepk
Copy link
Contributor

@piradeepk piradeepk commented May 2, 2019

Previously, only memoryLimitMiB was being set in the constructor. This would cause an unexpected validation error when a LoadBalancedEcsService was instantiated with memoryReservationMiB only specified. This fix correctly sets both fields.

Fixes #2263


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@piradeepk piradeepk requested review from SoManyHs and a team as code owners May 2, 2019 22:49
@SoManyHs SoManyHs changed the title fix(aws-ecs): memoryReservationLimit not being set in LoadBalancedEcsService fix(aws-ecs): memoryReservation not being set in LoadBalancedEcsService May 2, 2019
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add a test in test/test-l3s.ts?

Thanks!

@SoManyHs SoManyHs changed the title fix(aws-ecs): memoryReservation not being set in LoadBalancedEcsService fix(aws-ecs): set memoryReservation in LoadBalancedEcsService May 2, 2019
@SoManyHs SoManyHs changed the title fix(aws-ecs): set memoryReservation in LoadBalancedEcsService fix(aws-ecs): set memoryReservationMiB in LoadBalancedEcsService May 2, 2019
@piradeepk piradeepk force-pushed the fix-loadbalancedecsfargateservice branch from b3ca5be to cd3b105 Compare May 3, 2019 04:31
@piradeepk
Copy link
Contributor Author

Added and updated a test.

@piradeepk piradeepk force-pushed the fix-loadbalancedecsfargateservice branch from 3e1295c to a9fdf7f Compare May 3, 2019 21:37
@piradeepk
Copy link
Contributor Author

Squashed commits

@rix0rrr rix0rrr merged commit 6b50927 into aws:master May 6, 2019
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
)

Previously, only `memoryLimitMiB` was being set in the constructor. This would cause an unexpected validation error when a LoadBalancedEcsService was instantiated with `memoryReservationMiB` only specified. This fix correctly sets both fields.

Fixes aws#2263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants