awslint:construct-base-is-private: FooBase should not be public (internal) #2409
Labels
package/awscl
Cross-cutting issues related to the AWS Construct Library
Comments
eladb
added
package/awscl
4 tasks
eladb
pushed a commit
that referenced
this issue
May 1, 2019
Refactor the rule implementation of awslint such that the context of each linter is implemented as a `XxxReflection` class (i.e. `ConstructReflection`, `ResourceReflection`). This increases our ability to reuse the model extracted from the type system in other linters. - `awslint:construct-base-is-private` will recommend that XxxBase are internal (required merging some files in some places) - `awslint:resource-attribute`: implement missing attributes from several modules - In some places, move the `ImportedXxx` class into the import method as a local class (makes the implementation much nicer because it's closed by the function call). Misc: - update "foreach.sh" to ignore undefined npm scripts - update contribution guide with instructions on how to use foreach.sh Fixes #2426 Fixes #2409 BREAKING CHANGE: `s3.Bucket.domainName` renamed to `s3.Bucket.bucketDomainName`. * `codedeploy.IXxxDeploymentConfig.deploymentConfigArn` is now a property and not a method. * `ec2.SecurityGroupBase` is now private * `ec2.VpcNetworkBase` is now private * `kinesis.StreamBase` is now private * `kms.EncryptionKeyBase` is now private * `logs.LogGroupBase` is now private * `ssm.ParameterBase` is now private * `eks.ClusterBase` is now private * `codebuild.ProjectBase` is now private * `codecommit.RepositoryBase` is now private * `codedeploy.ServerDeploymentGroupBase` is now private * `eks.ClusterBase` is now private * `lambda.LayerVersionBase` is now private * `rds.DatabaseClusterBase` is now private * `secretsmanager.SecretBase` is now private * `ses.ReceiptRuleSetBase` is now private
SanderKnape
pushed a commit
to SanderKnape/aws-cdk
that referenced
this issue
May 14, 2019
…#2349) Refactor the rule implementation of awslint such that the context of each linter is implemented as a `XxxReflection` class (i.e. `ConstructReflection`, `ResourceReflection`). This increases our ability to reuse the model extracted from the type system in other linters. - `awslint:construct-base-is-private` will recommend that XxxBase are internal (required merging some files in some places) - `awslint:resource-attribute`: implement missing attributes from several modules - In some places, move the `ImportedXxx` class into the import method as a local class (makes the implementation much nicer because it's closed by the function call). Misc: - update "foreach.sh" to ignore undefined npm scripts - update contribution guide with instructions on how to use foreach.sh Fixes aws#2426 Fixes aws#2409 BREAKING CHANGE: `s3.Bucket.domainName` renamed to `s3.Bucket.bucketDomainName`. * `codedeploy.IXxxDeploymentConfig.deploymentConfigArn` is now a property and not a method. * `ec2.SecurityGroupBase` is now private * `ec2.VpcNetworkBase` is now private * `kinesis.StreamBase` is now private * `kms.EncryptionKeyBase` is now private * `logs.LogGroupBase` is now private * `ssm.ParameterBase` is now private * `eks.ClusterBase` is now private * `codebuild.ProjectBase` is now private * `codecommit.RepositoryBase` is now private * `codedeploy.ServerDeploymentGroupBase` is now private * `eks.ClusterBase` is now private * `lambda.LayerVersionBase` is now private * `rds.DatabaseClusterBase` is now private * `secretsmanager.SecretBase` is now private * `ses.ReceiptRuleSetBase` is now private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: