Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bootstrap): allow specifying the toolkit staging bucket name #2407

Merged
merged 4 commits into from
May 6, 2019
Merged

feat(bootstrap): allow specifying the toolkit staging bucket name #2407

merged 4 commits into from
May 6, 2019

Conversation

orangewise
Copy link
Contributor

Closes #2390

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@orangewise orangewise requested a review from a team as a code owner May 1, 2019 11:04
@orangewise
Copy link
Contributor Author

Is there a way to check the AWS CodeBuild errors?

eladb
eladb approved these changes May 1, 2019
View reviewed changes
packages/aws-cdk/bin/cdk.ts Outdated Show resolved Hide resolved
jogold
jogold reviewed May 1, 2019
View reviewed changes
packages/aws-cdk/aws-cdk Outdated Show resolved Hide resolved
@rix0rrr rix0rrr merged commit 3bfc641 into aws:master May 6, 2019
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
@orangewise @SanderKnape
feat(bootstrap): allow specifying the toolkit staging bucket name (aw…
bbd912d 
…s#2407)

Add a command line argument to specify the toolkit staging bucket name.

Closes aws#2390.
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogold jogold jogold left review comments

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdk bootstrap - specify staging bucket name
4 participants
@orangewise @eladb @jogold @rix0rrr