Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toolkit): don't fail when terminal width is 0 #2355

Merged
merged 2 commits into from
Apr 23, 2019
Merged

fix(toolkit): don't fail when terminal width is 0 #2355

merged 2 commits into from
Apr 23, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 23, 2019

On some CI systems the terminal width is reported as 0 (instead of
"unknown"), which causes table formatting to fail.

Enforce a minimum terminal width.

Fixes #2253.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@rix0rrr
fix(toolkit): don't fail when terminal width is 0
790e7a8 
On some CI systems the terminal width is reported as 0 (instead of
"unknown"), which causes table formatting to fail.

Enforce a minimum terminal width.

Fixes #2253.
@rix0rrr rix0rrr requested a review from a team as a code owner April 23, 2019 07:43
@rix0rrr rix0rrr merged commit 9c2220c into master Apr 23, 2019
@rix0rrr rix0rrr deleted the huijbers/min-col-width branch April 23, 2019 13:14
piradeepk pushed a commit to piradeepk/aws-cdk that referenced this pull request Apr 25, 2019
@rix0rrr @piradeepk
fix(toolkit): don't fail when terminal width is 0 (aws#2355)
54408c9 
On some CI systems the terminal width is reported as 0 (instead of
"unknown"), which causes table formatting to fail.

Enforce a minimum terminal width.

Fixes aws#2253.
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
@rix0rrr @SanderKnape
fix(toolkit): don't fail when terminal width is 0 (aws#2355)
314bea8 
On some CI systems the terminal width is reported as 0 (instead of
"unknown"), which causes table formatting to fail.

Enforce a minimum terminal width.

Fixes aws#2253.
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
@yosupo06 yosupo06 mentioned this pull request Nov 14, 2019
Merged
This was referenced Dec 12, 2019
Closed
Open
Open
@Secrus Secrus mentioned this pull request Dec 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminal size is 0 on CI and so diff and deploy throws exception when trying to create table of changes
3 participants
@rix0rrr @RomainMuller @NGL321