Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-events-targets): centralized module for cloudwatch event targets #2343

Merged
merged 13 commits into from
Apr 22, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Apr 22, 2019

Start moving all implementations of IEventRuleTarget into a centralized
module to adhere with the new AWS Construct Library guideline for integrations.

This change includes the implementation of the following event rule targets:

  • targets.SnsTopic
  • targets.CodeBuildProject

BREAKING CHANGE: sns.Topic no longer implements IEventRuleTarget. Use @aws-cdk/aws-events-targets.SnsTopic instead.

  • codebuild.Project no longer implements IEventRuleTarget. Use @aws-cdk/aws-events-targets.CodeBuildProject

Subsequent PRs will migrate the rest of the targets into this module.

  • Test that permissions are de-duplicated.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

…gets

Start moving all implementations of `IEventRuleTarget` into a centralized
module to adhere with the new AWS Construct Library guideline for integrations.

This change creates the aws-events-targets module and implements the SNS Topic
integration class.

Subsequent PRs will migrate the rest of the targets into this module.
@eladb eladb requested a review from rix0rrr April 22, 2019 09:46
@eladb eladb requested a review from a team as a code owner April 22, 2019 09:46
Elad Ben-Israel added 2 commits April 22, 2019 12:53
Move SID assignment from TopicPolicy to PolicyDocument so that it will
occur after statement deduplication.
@eladb eladb merged commit 1069938 into master Apr 22, 2019
@eladb eladb deleted the benisrae/events-targets-sns branch April 22, 2019 20:22
piradeepk pushed a commit to piradeepk/aws-cdk that referenced this pull request Apr 25, 2019
…gets (aws#2343)

Start moving all implementations of `IEventRuleTarget` into a centralized
module to adhere with the new AWS Construct Library guideline for integrations.

This change includes the implementation of the following event rule targets:

- `targets.SnsTopic`
- `targets.CodeBuildProject`

BREAKING CHANGE: `sns.Topic` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.SnsTopic` instead.
* `codebuild.Project` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.CodeBuildProject`
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
…gets (aws#2343)

Start moving all implementations of `IEventRuleTarget` into a centralized
module to adhere with the new AWS Construct Library guideline for integrations.

This change includes the implementation of the following event rule targets:

- `targets.SnsTopic`
- `targets.CodeBuildProject`

BREAKING CHANGE: `sns.Topic` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.SnsTopic` instead.
* `codebuild.Project` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.CodeBuildProject`
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 23, 2019
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants