Bug in LoadBalancedEc2Service -- must have at least one of 'memoryLimitMiB' or 'memoryReservationMiB' specified

[Fejuto]

memoryLimitMiB is not optional at the moment while it should be; validate doesn't check for memoryReservationMiB.

validate() {
        const ret = super.validate();
        if (util_1.isEc2Compatible(this.compatibility)) {
            // EC2 mode validations
            // Container sizes
            for (const container of this.containers) {
                if (!container.memoryLimitSpecified) {
                    ret.push(`ECS Container ${container.node.id} must have at least one of 'memoryLimitMiB' or 'memoryReservationMiB' specified`);
                }
            }
        }
        return ret;
    }

• CDK Version 0.28

[SoManyHs]

Hi @Fejuto,

Could you include the example you are trying to run? This validation exists in the task-definition.ts construct, but just want to be clear on your use case. Thanks!

[Fejuto]

    new ecs.LoadBalancedEc2Service(this, 'Service', {
      memoryReservationMiB: 7500,
      cluster: gameCluster.cluster,
      image: ecs.ContainerImage.fromAsset(this, 'Image', {
        directory: '../cosnode'
      })
    })

causes

C:\Users\Fejuto\Documents\git\idlegame\cdk\node_modules\@aws-cdk\cdk\lib\synthesis.ts:51
        throw new Error(`Validation failed with the following errors:\n  ${errorList}`);
              ^
Error: Validation failed with the following errors:
  [GameStack/Service/TaskDef] ECS Container web must have at least one of 'memoryLimitMiB' or 'memoryReservationMiB' specified
    at Synthesizer.synthesize (C:\Users\Fejuto\Documents\git\idlegame\cdk\node_modules\@aws-cdk\cdk\lib\synthesis.ts:51:15)
    at App.run (C:\Users\Fejuto\Documents\git\idlegame\cdk\node_modules\@aws-cdk\cdk\lib\app.ts:74:27)
    at process.App.process.once (C:\Users\Fejuto\Documents\git\idlegame\cdk\node_modules\@aws-cdk\cdk\lib\app.ts:51:45)
    at Object.onceWrapper (events.js:315:30)
    at emitOne (events.js:116:13)
    at process.emit (events.js:211:7)
    at process.emit (C:\Users\Fejuto\Documents\git\idlegame\cdk\node_modules\source-map-support\source-map-support.js:465:21)

[SoManyHs]

Hi @Fejuto, sorry for the delay in response. This should be fixed in #2463. Thanks for your patience!