feat(codepipeline): make the default CodePipeline Bucket have an encryption key #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
eladb
suggested changes
Apr 11, 2019
| @@ -159,7 +160,10 @@ export class Pipeline extends cdk.Construct implements IPipeline { | |||
| // If a bucket has been provided, use it - otherwise, create a bucket. | |||
| let propsBucket = props.artifactBucket; | |||
| if (!propsBucket) { | |||
| const encryptionKey = new kms.EncryptionKey(this, 'ArtifactsBucketEncryptionKey'); | |||
There was a problem hiding this comment.
Feels like something we should allow users to opt out from and also supply their own key.
There was a problem hiding this comment.
We already allow it - the customer can supply their own artifactBucket in props (notice that we check if (!propsBucket), and don't do any defaulting in that case).
There was a problem hiding this comment.
My comment was about the key, not about the bucket, but I guess you are right. If they want to customize the key, they can just pass in a custom bucket. Make sure to mention in the artifactBucket props that the bucket is encrypted.
…ve an encryption key. This is a prerequisite for having a nice cross-account experience (see aws#1924).
skinny85
force-pushed
the
feature/pipeline-default-bucket-add-kms
branch
from
f8f90b7
to
b69e4e1
Compare
|
Updated the |
eladb
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for having a nice cross-account experience
(see #1924).
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.