fix(aws-lambda): fix circular dependency with lambda and codedeploy #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to avoid circular dependencies
sam-goodwin
requested review from
RomainMuller,
skinny85 and
a team
as code owners
eladb
approved these changes
Apr 10, 2019
| @@ -110,7 +115,7 @@ export class Alias extends FunctionBase { | |||
| return super.metric(metricName, { | |||
| dimensions: { | |||
| FunctionName: this.underlyingLambda.functionName, | |||
| Resource: this.functionArn | |||
| Resource: `${this.underlyingLambda.functionArn}:${this.aliasName}` | |||
There was a problem hiding this comment.
Provide some reasoning for why we are doing it like this here. Reference an issue?
eladb
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2231
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.